[make:user] implement getUserIdentifier if required #862
Conversation
jrushlow
force-pushed
the
feature/make-user-identifier
branch
2 times, most recently
from
f5f7198
to
8a75a11
Compare
| @@ -3,7 +3,7 @@ | |||
| namespace <?= $namespace; ?>; | |||
|
|
|||
| use Symfony\Component\Security\Core\Exception\UnsupportedUserException; | |||
| use Symfony\Component\Security\Core\Exception\UsernameNotFoundException; | |||
| use Symfony\Component\Security\Core\Exception\<?= $uses_user_identifier ? 'UserNotFoundException' : 'UsernameNotFoundException' ?>; | |||
| <?= ($password_upgrader = interface_exists('Symfony\Component\Security\Core\User\PasswordUpgraderInterface')) ? "use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;\n" : '' ?> | |||
| use Symfony\Component\Security\Core\User\UserInterface; | |||
| use Symfony\Component\Security\Core\User\UserProviderInterface; | |||
There was a problem hiding this comment.
We really need to, at some point, write a util class where we plug all the use statements into... then we just dump echo $useStatements->render() in the template :p
There was a problem hiding this comment.
No kidding.. use statements are getting harder and harder to manage lately.. have a solution on the todo list ;)
| $getterIdentifierName = 'getUsername'; | ||
|
|
||
| // Check if we're using Symfony 5.3+ - UserInterface::getUsername() was replaced with UserInterface::getUserIdentifier() | ||
| if (class_exists(InMemoryUser::class)) { |
There was a problem hiding this comment.
This class DOES only exist on 5.3. But why did you choose this class specifically? Could we use something more direct like method_exists(Symfony\Component\Security\Core\User\User::class, 'getUserIdentifier')?
There was a problem hiding this comment.
User::class has been deprecated as of 5.3 && Renamed / Will be renamed to InMemoryUser::class
weaverryan
force-pushed
the
feature/make-user-identifier
branch
from
276e77c
to
1d83924
Compare
|
Thanks Jesse! |
handle
getUsername()->getUserIdentifier()in Symfony 5.3 symfony/symfony#40403